Remove dependency on window.event in ListView #20966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft/monaco-editor#371. The `event` property of Window is [nonstandard] and isn't supported by Firefox, breaking some of ListView's event-handling behavior. I checked for places where VSCode depends on `window.event` by removing it from `lib.d.ts` and building from scratch; the references in ListView were the only ones I found in `src/vs/base/browser`. There are also some references in non-browser parts of the codebase, but I assume that's fine since they work in Electron. [nonstandard]: https://developer.mozilla.org/en-US/docs/Web/API/Window/event
|
@rf-, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @alexandrudima to be potential reviewers. |
|
Hi @rf-, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
For completeness, here's the list of references that aren't covered by this PR: |
|
Wow, great catches, these are definitely oversights. |
|
Thanks for the quick response! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/monaco-editor#371.
The
eventproperty of Window is nonstandard and isn't supported by Firefox,breaking some of ListView's event-handling behavior.
I checked for places where VSCode depends on
window.eventby removing it fromlib.d.tsand building from scratch; the references in ListView were the onlyones I found in
src/vs/base/browser. There are also some references innon-browser parts of the codebase, but I assume that's fine since they work in
Electron.