feat: support concurrent chat progress messages #212300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyceerhl/western-bandicoot
connor4312
approved these changes
May 8, 2024
roblourens
reviewed
May 9, 2024
| this._proxy.$handleProgressChunk(this._request.requestId, progress) | ||
| .then((handle) => { | ||
| if (typeof handle === 'number' && task) { | ||
| task().then((res) => { |
There was a problem hiding this comment.
Can you call task() before waiting for $handleProgressChunk?
| @@ -106,6 +106,21 @@ export interface IChatProgressMessage { | |||
| kind: 'progressMessage'; | |||
| } | |||
|
|
|||
| export interface IChatTask extends IChatTaskDto { | |||
| task?: () => Promise<string | void>; | |||
There was a problem hiding this comment.
Can these be non-optional? I don't see where they are undefined
There was a problem hiding this comment.
Thanks, fixing both in #212372
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.