Support for notebook.format Code Action
#212750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoyokrazy
changed the title
notebook.format Code Action
rebornix
requested changes
May 16, 2024
src/vs/workbench/contrib/notebook/browser/contrib/format/notebookDefaultFormatter.ts
Outdated
Show resolved
Hide resolved
| const providedActions = await CodeActionParticipantUtils.getActionsToRun(model, formatCodeActionOnSave, excludes, languageFeaturesService, getActionProgress, token); | ||
| // warn the user if there are more than one provided format action, and there is no specified defaultFormatter | ||
| if (providedActions.validActions.length > 1 && !extensionId) { | ||
| logService.warn('More than one format code action is provided, the 0th one will be used. A default can be specified via `notebook.defaultFormatter` in your settings.'); |
There was a problem hiding this comment.
later we can show a quick pick.
src/vs/workbench/contrib/notebook/browser/contrib/saveParticipants/saveParticipants.ts
Outdated
Show resolved
Hide resolved
rebornix
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #212381
Refer to the linked issue for extensibility rules, functionality is laid out here.