Properly handle errors thrown from renderer while invoking the chat agent #213080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever
connor4312
previously approved these changes
May 20, 2024
connor4312
approved these changes
May 21, 2024
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
May 22, 2024
…gent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
…gent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we throw out of ChatService, then the request can't be canceled and stays "generating" forever