Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve accessibility help dialog kbs in accessibleViewService #213107

Merged
merged 5 commits into from
May 20, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented May 20, 2024

Adopted for the editor, comments, notebook, chat, and extension contributed accessibility help dialogs so far

part of #210695

deferring terminal, diff editor, and other accessible views to a different PR

@meganrogge meganrogge marked this pull request as draft May 20, 2024 22:02
@meganrogge meganrogge changed the title resolve all accessibility help dialog kbs in accessibleViewService resolve accessibility help dialog kbs in accessibleViewService May 20, 2024
@meganrogge meganrogge marked this pull request as ready for review May 20, 2024 22:46
@meganrogge meganrogge enabled auto-merge (squash) May 20, 2024 22:47
@vscodenpa vscodenpa added this to the May 2024 milestone May 20, 2024
justschen
justschen previously approved these changes May 20, 2024
@meganrogge meganrogge disabled auto-merge May 20, 2024 22:55
@meganrogge meganrogge enabled auto-merge (squash) May 20, 2024 23:10
@meganrogge meganrogge merged commit 4b45180 into main May 20, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/resolve-all-kbs branch May 20, 2024 23:14
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants