Avoid request id collisions in pendingRPCReplies #21406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastMessageId should have same scope as pendingRPCReplies so different calls to createRPC can't have request id collisions.
|
@nicksnyder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers. |
|
@nicksnyder, |
nicksnyder
added a commit
to sourcegraph/vscode
that referenced
this pull request
Feb 28, 2017
Bug exposed by introduction of multiple workspaces Upstream at microsoft#21406
|
Nice catch! 👍 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastMessageId should have same scope as pendingRPCReplies so different calls to createRPC can't have request id collisions.