Output in horizontal panel #2146
Conversation
…itor (causes api tests to fail)
| @@ -45,3 +29,25 @@ registerMode({ | |||
| moduleId: 'vs/workbench/parts/output/common/outputMode', | |||
| ctorName: 'OutputMode' | |||
| }); | |||
|
|
|||
| // Register Output Panel | |||
| (<panel.PanelRegistry>platform.Registry.as(panel.Extensions.Panels)).registerPanel(new panel.PanelDescriptor( | |||
There was a problem hiding this comment.
@isidorn do not forget to add the panel to the same buildfile.js where we added REPL so that the loader can load it
There was a problem hiding this comment.
@bpasero for some reason it is working wihtout it also. I can add it for precaution
There was a problem hiding this comment.
Thats weird, but keep in mind it has to be a built version of VS Code!
There was a problem hiding this comment.
Stupid me, forgot it is only in build.
✔️
| options.wrappingColumn = this.defaultWrappingColumn; // otherwise make sure to restore the defaults | ||
| options.lineNumbers = this.defaultLineNumbers; // otherwise make sure to restore the defaults | ||
| } | ||
| options.wrappingColumn = this.defaultWrappingColumn; // otherwise make sure to restore the defaults |
There was a problem hiding this comment.
@isidorn suggest to remove the concept of defaultWrappingColumn and defaultLineNumbers because it was only needed for the outputEditorInput and this now moved nicely into the outputPanel
| } | ||
|
|
||
| public dispose(): void { | ||
| this.outputPanel.dispose(); |
There was a problem hiding this comment.
@isidorn suggest to not dispose outputPanel here, it will be handled when the compositePart is disposed
No description provided.