chore: update to electron 30 #215406
Merged
chore: update to electron 30 #215406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
electron-30.x.y
branch
5 times, most recently
from
cdbcba3 to
a8f7d1c
Compare
deepak1556
force-pushed
the
electron-30.x.y
branch
3 times, most recently
from
874284c to
375dcbf
Compare
deepak1556
force-pushed
the
electron-30.x.y
branch
2 times, most recently
from
82a145f to
31bd299
Compare
deepak1556
force-pushed
the
electron-30.x.y
branch
3 times, most recently
from
faa6fd6 to
33083e5
Compare
|
@chrmarti please review e4dd212 @connor4312 please review 6c1649e @bpasero for rest of the files. |
deepak1556
commented
Jul 8, 2024
| @@ -16,7 +16,7 @@ steps: | |||
| inputs: | |||
| versionSource: fromFile | |||
| versionFilePath: .nvmrc | |||
| nodejsMirror: https://github.com/joaomoreno/node-mirror/releases/download | |||
There was a problem hiding this comment.
Addressed in joaomoreno/node-mirror#1
/cc @joaomoreno
|
lgtm |
bpasero
previously approved these changes
Jul 8, 2024
bpasero
previously approved these changes
Jul 8, 2024
|
PR is ready for merge, but I will merge it tomorrow since the new dependency has not been cached yet by the registry mirror. |
- Updates vscode-universal-bundler to support x64ArchFiles option - Kerberos starts building universal binaries which should now be skipped from lipo step via x64ArchFiles - Skips bundling *.mk files
deepak1556
force-pushed
the
electron-30.x.y
branch
from
19fa521 to
afda215
Compare
bpasero
approved these changes
Jul 9, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
* chore: update electron@30.0.9 * chore: update rpm deps * chore: bump electron@30.1.2 * fix: update kerberos for Node.js 20.x Refs mongodb-js/kerberos@c1f7aca * fix: use shell when spawning .bat or .cmd files Refs nodejs/node@6627222409 * fix: update @vscode/test-electron@2.4.0 Refs microsoft/vscode-test@3f7a3cc * fixup! use shell when spawning .bat or .cmd files * chore: bump nodejs@20.14.0 internal build * ci: skip nodejsMirror for 20.14.0 due to missing builds * fixup! use shell when spawning .bat or .cmd files * chore: update debian deps * fixup! skip nodejsMirror for 20.14.0 due to missing builds * fix: universal build - Updates vscode-universal-bundler to support x64ArchFiles option - Kerberos starts building universal binaries which should now be skipped from lipo step via x64ArchFiles - Skips bundling *.mk files * chore: bump distro
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214394
Fixes #215924