Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #218626 #219148

Merged
merged 16 commits into from
Aug 1, 2024
Merged

Fixes #218626 #219148

merged 16 commits into from
Aug 1, 2024

Conversation

swordensen
Copy link
Contributor

This is to resolve #218626

Basically, it prevents windows from popping up when dragging files over to extensions from the OS's file explorer.

You can test this functionality by performing the following steps:

  1. clone repo https://github.com/maxbublik/vscode-customeditor-drop
  2. press f5 to open demo repo as an extension
  3. drag and drop any file into the extension editor while holding shift
  4. notice that a new window did not appear

@swordensen
Copy link
Contributor Author

I added a fix that addresses #219047

@swordensen
Copy link
Contributor Author

swordensen commented Jul 8, 2024

Since #219896 got merged I will need to bring back the original changes on this PR before it gets merged.

I am going to change this to a draft status.

[edit] #219896 did not merge into master. That's really cool. I will undraft this

@swordensen swordensen marked this pull request as draft July 8, 2024 16:55
@swordensen swordensen marked this pull request as ready for review July 9, 2024 15:37
@mjbvz mjbvz added this to the July 2024 milestone Jul 12, 2024
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 12, 2024

Thanks for following up! Will get this into the next insiders build which should go out at the start of next week

@swordensen
Copy link
Contributor Author

Thanks for following up! Will get this into the next insiders build which should go out at the start of next week

no problem! and no rush on my end. I'm sorry for any headaches my last PR caused. It feels good to help fix it!

@swordensen
Copy link
Contributor Author

I was thinking about this again today and I am a little concerned that if this fix PR is not merged before the July release we may encounter the same issue(s) with the June release.

Since, I don't think the reversion here #219896 would be included. I am not 100% sure about that though.

@mjbvz mjbvz modified the milestones: July 2024, August 2024 Jul 24, 2024
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! Let's try this again for the August release since we'll have more testing in insiders

@mjbvz mjbvz merged commit d00533a into microsoft:main Aug 1, 2024
6 checks passed
BABA983 pushed a commit to BABA983/vscode that referenced this pull request Aug 2, 2024
* preventing default on drop events to prevent files from opening in a new window

* adding a fix that addresses microsoft#219047

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants