-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #218626 #219148
Fixes #218626 #219148
Conversation
I added a fix that addresses #219047 |
Thanks for following up! Will get this into the next insiders build which should go out at the start of next week |
no problem! and no rush on my end. I'm sorry for any headaches my last PR caused. It feels good to help fix it! |
I was thinking about this again today and I am a little concerned that if this fix PR is not merged before the July release we may encounter the same issue(s) with the June release. Since, I don't think the reversion here #219896 would be included. I am not 100% sure about that though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up! Let's try this again for the August release since we'll have more testing in insiders
* preventing default on drop events to prevent files from opening in a new window * adding a fix that addresses microsoft#219047 --------- Co-authored-by: Matt Bierner <matb@microsoft.com>
This is to resolve #218626
Basically, it prevents windows from popping up when dragging files over to extensions from the OS's file explorer.
You can test this functionality by performing the following steps: