Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try out new YAML grammar #219833

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Try out new YAML grammar #219833

merged 2 commits into from
Jul 3, 2024

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 3, 2024

Part of #180523

@alexr00 alexr00 self-assigned this Jul 3, 2024
@alexr00 alexr00 mentioned this pull request Jul 3, 2024
Closed
@alexr00 alexr00 marked this pull request as ready for review July 3, 2024 09:42
@vscodenpa vscodenpa added this to the July 2024 milestone Jul 3, 2024
@alexr00 alexr00 merged commit 9255a27 into main Jul 3, 2024
6 checks passed
@alexr00 alexr00 deleted the alexr00/vivid-sailfish branch July 3, 2024 10:13
This was referenced Jul 5, 2024
Closed
Closed
@RedCMD
Copy link
Contributor

RedCMD commented Jul 8, 2024 •
edited
Loading

I've fixed some issues:

@alexr00
Copy link
Member Author

alexr00 commented Jul 9, 2024

👍 updating here: #221244

aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this pull request Jul 10, 2024
@alexr00 @aaronchucarroll
Try out new YAML grammar (microsoft#219833)
2f6345c 
* Try out new YAML grammar
Part of microsoft#180523

* Pull in other/plain update
@mjbvz mjbvz mentioned this pull request Aug 5, 2024
Closed
alexr00 added a commit that referenced this pull request Aug 6, 2024
@alexr00
Revert "Try out new YAML grammar (#219833)"
4955826 
This reverts commit 9255a27.
alexr00 added a commit that referenced this pull request Aug 6, 2024
@alexr00
VSCode 1.92 YAML grammar breaks MDX syntax highlighting (#224942)
75cfbd7 
* Revert "Update YAML grammar (#221244)"

This reverts commit c2df206.

* Revert "Try out new YAML grammar (#219833)"

This reverts commit 9255a27.
zongou pushed a commit to zongou/vscode that referenced this pull request Aug 13, 2024
@alexr00 @zongou
VSCode 1.92 YAML grammar breaks MDX syntax highlighting (microsoft#22…
46c9888 
…4942)

* Revert "Update YAML grammar (microsoft#221244)"

This reverts commit c2df206.

* Revert "Try out new YAML grammar (microsoft#219833)"

This reverts commit 9255a27.
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@alexr00 @RedCMD @bpasero @vscodenpa