Support for TSServer Request Cancelation #22437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18053
Adds support for canceling ongoing TSServer requests using per request cancelation. This PR is a WIP currently.
@vladima and @mhegazy can you take a quick look at the PR to see if it looks correct. I keep getting error from the TSServer that look like this:
It seems the expected request is never set. I think there is a bug on this line with
currentRequestId = currentRequestId
: https://github.com/Microsoft/TypeScript/blob/6117ed77087b5d84774ee545bd3cad3d059caa75/src/server/cancellationToken/cancellationToken.ts#L51Here's a PR with a fix: microsoft/TypeScript#14594