Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to fix compile error with noImplicitAny #22460

Merged
merged 4 commits into from
Mar 21, 2017
Merged

Refactor to fix compile error with noImplicitAny #22460

merged 4 commits into from
Mar 21, 2017

Conversation

katainaka0503
Copy link
Contributor

@katainaka0503 katainaka0503 commented Mar 11, 2017 •
edited
Loading

Some refactorings

  • Introduced index signature.
  • Fixed to use ES6 Map properly.
  • Fixed type signature.
  • Fixed to use foo.bar instead of foo[bar]

All of these changes fix compile errors which occur if noImplicitAny in tsconfig.json is set to true.

@mention-bot
Copy link

@katainaka0503, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @alexandrudima to be potential reviewers.

@msftclas
Copy link

@katainaka0503,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@katainaka0503 katainaka0503 changed the title Refactor to decrease compile error with noImplicitAny Refactor to fix compile error with noImplicitAny Mar 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 20, 2017

More types 👍

@jrieken jrieken self-requested a review March 20, 2017 14:53
@jrieken
Copy link
Member

jrieken commented Mar 20, 2017

👍

@jrieken jrieken removed their assignment Mar 20, 2017
@aeschli
Copy link
Contributor

aeschli commented Mar 20, 2017

👍

@aeschli aeschli removed their assignment Mar 20, 2017
@bpasero
Copy link
Member

bpasero commented Mar 20, 2017

LGTM, thanks 👍

@bpasero bpasero self-requested a review March 20, 2017 16:34
@bpasero bpasero removed their assignment Mar 20, 2017
@jrieken jrieken merged commit d4504b9 into microsoft:master Mar 21, 2017
@jrieken
Copy link
Member

jrieken commented Mar 21, 2017

Merged. Thanks @katainaka0503 for the PR.

@jrieken jrieken added this to the March 2017 milestone Mar 21, 2017
@katainaka0503
Copy link
Contributor Author

@jrieken Thank you for the merge!

@jrieken
Copy link
Member

jrieken commented Mar 21, 2017

No problem, tho keep in mind that larger PRs esp. those that cut across different owners are harder for us to coordinate and it's better send a heads up note first

@katainaka0503
Copy link
Contributor Author

I am terribly sorry.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@jrieken jrieken jrieken approved these changes

@Tyriar Tyriar Tyriar approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
8 participants
@katainaka0503 @mention-bot @msftclas @Tyriar @jrieken @aeschli @bpasero @alexdima