Fix debug console is cleared on style changed #224694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BABA983
force-pushed
the
fix-debug-console-cleared-on-style-changed
branch
from
ee6c1ca
to
426836c
Compare
BABA983
force-pushed
the
fix-debug-console-cleared-on-style-changed
branch
from
426836c
to
25ade0f
Compare
BABA983
force-pushed
the
fix-debug-console-cleared-on-style-changed
branch
from
25ade0f
to
caf91a5
Compare
|
@roblourens ping in case you miss that. |
lszomoru
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #200369
It seems when viewPanel body visibility changed the height was changed from 0 to the previous render height.
The listView.ts#L1439 will probe dynamic height when executing
this.tree?.rerender.After the calculation it removeItemFromDOM but not insertItemInDOM them back which result in looks like was cleared.
The fix was to insert the previous dom back into its container.