Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize shellIntegration API #224744

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Finalize shellIntegration API #224744

merged 1 commit into from
Aug 7, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 4, 2024

Fixes #145234

@Tyriar Tyriar added this to the August 2024 milestone Aug 4, 2024
@Tyriar Tyriar self-assigned this Aug 4, 2024
mjbvz
mjbvz approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Let's get Joh's review as well but lgtm

@Tyriar Tyriar merged commit cf347ed into main Aug 7, 2024
6 checks passed
@Tyriar Tyriar deleted the tyriar/145234_2 branch August 7, 2024 13:55
@rgrunber rgrunber mentioned this pull request Sep 9, 2024
Open
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@songjianet songjianet songjianet approved these changes

@mjbvz mjbvz mjbvz approved these changes

@jrieken jrieken jrieken approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

Expose shell integration command knowledge to extensions
4 participants
@Tyriar @jrieken @mjbvz @songjianet