chore: update electron@30.3.1

[deepak1556]

https://releases.electronjs.org/release/compare/v30.1.2/v30.3.1

Fixes #213780
Fixes #217220

Features:

• WCO support for linux is now available in the runtime /cc @benibenj @bpasero

[deepak1556]

Following task smoke tests fail consistently on linux product build with issue opening integrated terminal, logs show the following error, fyi @Tyriar

The terminal process failed to launch: A native exception occurred during launch ("fd" must be a positive integer: undefined)

Tried a couple of debugging steps:

• Error is from https://github.com/microsoft/node-pty/blob/8fc21c99bf281cb2fd2921f89660cbf8649c4a2b/src/unixTerminal.ts#L117 specifically from the check in https://github.com/nodejs/node/blob/9e6c526f6c4e21b96f999869ceb265fb1891bf15/lib/tty.js#L55-L56 where fd is the result of forkpty
• Interestingly, dev pipeline does not fail on the same smoke tests https://dev.azure.com/vscode/VSCode/_build/results?buildId=128302&view=logs&j=15f6beb8-c39c-5fa4-f1fe-6e73c89d1002&t=f548697b-f1e3-56d7-b20f-10575b2a648b
• I was also unable to repro the failure locally by using the product build from the failing CI pipeline

yarn smoketest-no-compile --build <insiders-build>

• No changes in either Node.js update or Electron update stands out that could cause this regression.
• Not so surprising but using the node-pty version before the tty change does pass in product builds https://dev.azure.com/monacotools/Monaco/_build/results?buildId=287174&view=results, maybe this was an issue we had all along but still doesn't answer why only the current update makes it more consistent in CI.
• Running product build with OSS electron to rule out any internal patches also repros the failure, agents and software included are same for both pipelines (product and dev). Only difference is running out of sources vs bundled build. Wonder if it is some kind of sandbox issue, will run with sandbox disabled as next step.

[deepak1556]

Wonder if it is some kind of sandbox issue, will run with sandbox disabled as next step.

Still fails, I am out of ideas with a lack of repro. We need some logging in the node-pty module. @Tyriar @meganrogge can I disable the smoke tests to unblock this PR and create a follow-up issue to debug further. It would also help to see if we get any real world issues with repro around this failure.

[Tyriar]

@deepak1556 if it's erroring at tty.ReadStream it seems like this would totally brick a terminal. I'll leave it up to you on whether this should be merged in now or not based on what you think the impact will be and how fast better logging can be put in place.

[deepak1556]

The problem is that I don't have an idea of the impact given the issue only repros in the product CI. I will try these as next steps,

1. Disable the tests and merge the Electron update
2. Add logging to see why fd is invalid in CI
3. Additionally, wait for some real world repro to turn up
4. Enable back the tests eventually

[Tyriar]

CI network flake?