Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding check of full folder name instead of suffix #22532

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Adding check of full folder name instead of suffix #22532

merged 1 commit into from
Mar 13, 2017

Conversation

timbanaveen
Copy link

Fixes #22160

@mention-bot
Copy link

@timbanaveen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.

@msftclas
Copy link

@timbanaveen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@timbanaveen timbanaveen mentioned this pull request Mar 13, 2017
Closed
@bpasero bpasero self-assigned this Mar 13, 2017
@bpasero bpasero requested a review from Tyriar March 13, 2017 14:43
@bpasero bpasero added this to the March 2017 milestone Mar 13, 2017
Tyriar
Tyriar approved these changes Mar 13, 2017
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@bpasero bpasero merged commit 8884b22 into microsoft:master Mar 13, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.

Path truncation doesn't correctly truncate for 3 same named files in similar folders
5 participants
@timbanaveen @mention-bot @msftclas @Tyriar @bpasero