feat: collapse codeblocks in editing sessions

[joyceerhl]

No description provided.

[roblourens]

Seems wrong to render new content inside layout?

[roblourens]

Don't these already open the file when you click? Do you just need to fix the data-href somewhere?

[joyceerhl]

Don't these already open the file when you click?

I guess that's because these are <a /> tags in the existing use case, so I could set them up the same way here

Seems wrong to render new content inside layout?

We get new information about whether to change the presentation asynchronously, after the codeblock has already started rendering.

vscode/src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts

Lines 105 to 110 in 2cf3fec

	codemapperUri = undefined; // will be set async
	public get uri() {
	// here we must do a getter because the ref.object is rendered
	// async and the uri might be undefined when it's read immediately
	return ref.object.uri;
	}

So I'm relying on firing onDidChange when that happens. Would it be better to add a render method instead that can change the presentation of the codeblock?

[roblourens]

Yeah, either the whole Part should rerender, via hasSameContent returning false, or it should re-render itself and fire _onDidChangeHeight.

[roblourens]

I don't really have an opinion whether we avoid using <a> entirely and make it more like a button, or use an <a> tag for the codeblock version, but it would be easier to follow if the two cases work the same.

[roblourens]

I don't even follow why I have this layout method, since it's only called like this

markdownPart.addDisposable(markdownPart.onDidChangeHeight(() => {
			markdownPart.layout(this._currentLayoutWidth);

Seems like it could be simplified, I think it's leftover from my IChatContentPart refactoring