fix: improve settings descriptions for actions triggered on save

[elias-pap]

closes #230051

[elias-pap]

@microsoft-github-policy-service agree

[justschen]

Please also take a look at editor.codeActions.triggerOnFocusChange, which will save in certain scenarios:

1. auto save is afterDelay
2. editor code actions on save are set to always.
3. focus is changed

note that this only works atm for editor code actions on save, and not notebooks.

[elias-pap]

Please also take a look at editor.codeActions.triggerOnFocusChange, which will save in certain scenarios:

Not sure what you mean. This setting does not "save" in certain scenarios, it only triggers the code actions under some conditions, one of them being auto save is set to afterDelay. So the save happens automatically after delay, not from this setting. Also, the code actions run automatically, but not because (or at the time of) the editor is being saved.

[justschen]

@elias-pap sorry, that's what I meant. I added that setting a few iterations ago since users with afterDelay on wanted to still be able to run code actions.

my point of bringing it up is because we don't mention that this setting which will run code actions when the file isn't saved explicitly.

maybe adding a mention of this setting somehow could be helpful, although it is getting a bit verbose

[elias-pap]

@elias-pap sorry, that's what I meant. I added that setting a few iterations ago since users with afterDelay on wanted to still be able to run code actions.

Right, that's what I had guessed.

my point of bringing it up is because we don't mention that this setting which will run code actions when the file isn't saved explicitly.

maybe adding a mention of this setting somehow could be helpful, although it is getting a bit verbose

I agree that it's a bit overkill. These settings are called "formatOnSave" and "codeActionsOnSave", so it's better to focus on what happens on save instead of repeating descriptions from other settings. The word "only" can be removed to avoid contradictions ("will only be run when the file is saved explicitly" -> "will be run when the file is saved explicitly"), and that leaves room for other settings (like the one you mention) to trigger code actions as well.

The point of this fix is to clarify that the user can both have autoSave -> afterDelay enabled, and format the file (or run code actions) by saving manually, at the same time.

[justschen]

awesome! thanks for the patience, looks good to me 👍