add new profile icons #230117
Merged
add new profile icons #230117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Sep 30, 2024
| @@ -1048,7 +1048,7 @@ class ProfileIconRenderer extends ProfilePropertyRenderer { | |||
| }, true); | |||
|
|
|||
| if (hoverWidget) { | |||
| iconSelectBox.layout(new Dimension(486, 260)); | |||
| iconSelectBox.layout(new Dimension(486, 292)); | |||
There was a problem hiding this comment.
Should we change here too?
There was a problem hiding this comment.
Profiles has relatively smaller set of icons and wanted them to fit the content. In your case, I believe there is a large set you are not showing this as an hover like in profiles editor. So it should be fine not to have same height.
Tyriar
approved these changes
Sep 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.