Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test failure - changing selectors depending on app quality #234181

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

aiday-mar
Copy link
Contributor

Smoke test failure - changing selectors depending on app quality

@aiday-mar aiday-mar self-assigned this Nov 19, 2024
@aiday-mar aiday-mar marked this pull request as ready for review November 21, 2024 08:42
@aiday-mar aiday-mar enabled auto-merge (squash) November 21, 2024 08:42
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 21, 2024
@aiday-mar aiday-mar marked this pull request as draft November 21, 2024 08:45
auto-merge was automatically disabled November 21, 2024 08:45

Pull request was converted to draft

@aiday-mar
Copy link
Contributor Author

Before merging this PR will be ran on the build CI, both Insiders and Stable to make sure that this PR does not break the pipeline.

@aiday-mar aiday-mar marked this pull request as ready for review November 21, 2024 10:37
@aiday-mar aiday-mar enabled auto-merge (squash) November 21, 2024 10:37
@aiday-mar aiday-mar merged commit b69589c into main Nov 21, 2024
42 checks passed
@aiday-mar aiday-mar deleted the vertical-gull branch November 21, 2024 10:58
osortega pushed a commit that referenced this pull request Nov 26, 2024
…4181)

* changing selector depending on app quality smoke test

* using correct selector

* resetting to just insiders

* focusing if not focused after event

* removing dom node focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants