add support for file/folder terminal completions #234289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Nov 20, 2024
meganrogge
commented
Nov 20, 2024
meganrogge
commented
Nov 20, 2024
meganrogge
commented
Nov 20, 2024
Tyriar
previously requested changes
Nov 20, 2024
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Nov 20, 2024
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts
Outdated
Show resolved
Hide resolved
…nalCompletionService.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
meganrogge
force-pushed
the
merogge/folder
branch
from
3ab31f1
to
2cb9c07
Compare
karthiknadig
approved these changes
Nov 21, 2024
Tyriar
reviewed
Nov 21, 2024
Comment on lines
+23
to
+24
| // fixes a bug with file/folder completions brought about by the '.' command | ||
| const filter = (cmd: string) => cmd && cmd !== '.'; |
There was a problem hiding this comment.
We do want ., I didn't test but assume it's not working based on this. Tracked in #234351
osortega
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for any of the completion spec / options / arg names and refactors the spec completion evaluation into a function that should make it easy to add tests for.
to do / defer: