fix replacing end of line with newline #2587
Conversation
|
Hi @sparecycles, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| @@ -163,7 +163,7 @@ export abstract class TextAreaState { | |||
| if (currentSelectionStart === currentSelectionEnd) { | |||
| // composition accept case | |||
| // [blahblah] => blahblah| | |||
| if (previousValue === currentValue && previousSelectionStart === 0 && previousSelectionEnd === previousValue.length && currentSelectionStart === currentValue.length) { | |||
| if (previousValue === currentValue && previousSelectionStart === 0 && previousSelectionEnd === previousValue.length && currentSelectionStart === currentValue.length && currentValue !== '\n') { | |||
There was a problem hiding this comment.
When replacing the end-of-line with a newline, this check results in no typing being recognized (well, on the first typing, on the second it is recorded). I added this specific check for enter but I'm not convinced it's correct.
|
@sparecycles Thank you! I ended up using a very similar approach inspired from your change in dd751e4 --- to distinguish the composition case in the textareaState by checking if the string contains newline --- and to keep track of the version id emitted via contentChange and emit a dummy event if it fell behind. Thank you once again! -- now I just need to rewrite that logic -- I hate it :) |
|
Looks good! Glad to have helped. |
Fixes #2586