Support brokering from Linux x64 and Intel Macs #278689
Conversation
This grabs the native files directly since the ones at the root are not expected to work in our cases, namely Intel Mac where we use arm machines to build the x64 build.
There was a problem hiding this comment.
Pull Request Overview
This PR enables native broker support for Microsoft authentication on Linux x64 and Intel Mac platforms, addressing issues #278687 and #278688. Previously, only Windows and ARM64 Macs were supported for broker-based authentication.
Key changes:
- Removed platform restrictions that prevented Linux and Intel Macs from using native broker
- Updated webpack configuration to copy platform-specific native modules for Linux x64 and all macOS architectures
- Restructured native module paths to use platform-specific folder structure (
windows/,macos/,linux/)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
extensions/microsoft-authentication/src/node/cachedPublicClientApplication.ts |
Removed platform check that limited broker support to Windows and macOS only, allowing Linux to use native broker |
extensions/microsoft-authentication/extension.webpack.config.js |
Added Linux platform support, restructured native file copy patterns with platform-specific folders, and enabled all macOS architectures instead of just ARM64 |
| if ( | ||
| (isWindows && windowsArches.includes(arch)) || | ||
| isMacOS || | ||
| (isLinux && linuxArches.includes(arch)) |
There was a problem hiding this comment.
macOS is now included unconditionally without architecture filtering (line 38), while Windows and Linux still filter by architecture (lines 37, 39). This inconsistency could be intentional to support both Intel (x64) and ARM64 Macs, but the from pattern on line 45 uses ${arch} which will still be architecture-specific. This means the copy will fail for unsupported architectures if the native files don't exist in that path. Consider either:
- Adding architecture filtering for macOS if only specific architectures are supported, or
- Documenting that all macOS architectures are supported and ensuring native files exist for all architectures in the expected paths.
Fixes #278687
Fixes #278688