fix: show restart extensions notification when disabling from Running Extensions view #285631
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Extensions view When an extension is disabled from the Running Extensions view context menu, the user was not notified that extensions need to be restarted for the change to take effect. This was inconsistent with the Extensions view behavior. Now, a notification is shown with a 'Restart Extensions' button that allows the user to restart extensions immediately and apply the change. Fixes microsoft#250201
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing notification when disabling extensions from the Running Extensions view. Previously, users were not notified that extensions need to be restarted for the change to take effect, creating an inconsistency with the main Extensions view behavior.
Key Changes:
- Added notification prompts with "Restart Extensions" button after disabling extensions from the Running Extensions view context menu
- Ensures users are informed that a restart is needed to apply the disablement
Comment on lines
+492
to
+510
| this._notificationService.prompt( | ||
| Severity.Info, | ||
| nls.localize('restartExtensionsRequired', "The extension has been disabled. Please restart extensions to apply the change."), | ||
| [{ | ||
| label: nls.localize('restartExtensions', "Restart Extensions"), | ||
| run: () => this._extensionsWorkbenchService.updateRunningExtensions() | ||
| }] | ||
| ); | ||
| })); | ||
| actions.push(new Action('runtimeExtensionsEditor.action.disable', nls.localize('disable', "Disable"), undefined, true, async () => { | ||
| await this._extensionsWorkbenchService.setEnablement(e.element!.marketplaceInfo!, EnablementState.DisabledGlobally); | ||
| this._notificationService.prompt( | ||
| Severity.Info, | ||
| nls.localize('restartExtensionsRequired', "The extension has been disabled. Please restart extensions to apply the change."), | ||
| [{ | ||
| label: nls.localize('restartExtensions', "Restart Extensions"), | ||
| run: () => this._extensionsWorkbenchService.updateRunningExtensions() | ||
| }] | ||
| ); |
There was a problem hiding this comment.
The notification code is duplicated in both the "Disable (Workspace)" and "Disable" actions. Consider extracting this into a helper function to reduce duplication and improve maintainability. For example, create a private method that shows the notification and call it from both actions.
Member
|
Closing this PR because the associated feature request is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an extension is disabled from the Running Extensions view context menu, the user was not notified that extensions need to be restarted for the change to take effect. This was inconsistent with the Extensions view behavior.
Changes
Added a notification with a 'Restart Extensions' button that appears after disabling an extension from the Running Extensions view. This matches the behavior of the main Extensions view.
Modified File
src/vs/workbench/contrib/extensions/browser/abstractRuntimeExtensionsEditor.tsBefore
After
Fixes #250201