Skip to content

UX: Add 'Don't Show Again' prompt for restarting extensions #285658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murataslan1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UX: Add 'Don't Show Again' prompt for restarting extensions #285658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions src/vs/workbench/contrib/extensions/browser/abstractRuntimeExtensionsEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { ILabelService } from '../../../../platform/label/common/label.js';
import { WorkbenchList } from '../../../../platform/list/browser/listService.js';
import { INotificationService, Severity } from '../../../../platform/notification/common/notification.js';
import { Registry } from '../../../../platform/registry/common/platform.js';
import { IStorageService } from '../../../../platform/storage/common/storage.js';
import { IStorageService, StorageScope, StorageTarget } from '../../../../platform/storage/common/storage.js';
import { ITelemetryService } from '../../../../platform/telemetry/common/telemetry.js';
import { editorBackground } from '../../../../platform/theme/common/colorRegistry.js';
import { IThemeService } from '../../../../platform/theme/common/themeService.js';
Expand Down Expand Up @@ -88,15 +88,15 @@ export abstract class AbstractRuntimeExtensionsEditor extends EditorPane {
@INotificationService private readonly _notificationService: INotificationService,
@IContextMenuService private readonly _contextMenuService: IContextMenuService,
@IInstantiationService protected readonly _instantiationService: IInstantiationService,
@IStorageService storageService: IStorageService,
@IStorageService private readonly _storageService: IStorageService,
@ILabelService private readonly _labelService: ILabelService,
@IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService,
@IClipboardService private readonly _clipboardService: IClipboardService,
@IExtensionFeaturesManagementService private readonly _extensionFeaturesManagementService: IExtensionFeaturesManagementService,
@IHoverService private readonly _hoverService: IHoverService,
@IMenuService private readonly _menuService: IMenuService,
) {
super(AbstractRuntimeExtensionsEditor.ID, group, telemetryService, themeService, storageService);
super(AbstractRuntimeExtensionsEditor.ID, group, telemetryService, themeService, _storageService);

this._list = null;
this._elements = null;
Expand Down Expand Up @@ -487,8 +487,8 @@ export abstract class AbstractRuntimeExtensionsEditor extends EditorPane {
actions.push(new Separator());

if (e.element.marketplaceInfo) {
actions.push(new Action('runtimeExtensionsEditor.action.disableWorkspace', nls.localize('disable workspace', "Disable (Workspace)"), undefined, true, () => this._extensionsWorkbenchService.setEnablement(e.element!.marketplaceInfo!, EnablementState.DisabledWorkspace)));
actions.push(new Action('runtimeExtensionsEditor.action.disable', nls.localize('disable', "Disable"), undefined, true, () => this._extensionsWorkbenchService.setEnablement(e.element!.marketplaceInfo!, EnablementState.DisabledGlobally)));
actions.push(new Action('runtimeExtensionsEditor.action.disableWorkspace', nls.localize('disable workspace', "Disable (Workspace)"), undefined, true, () => this._disableExtensionWithPrompt(e.element!.marketplaceInfo!, EnablementState.DisabledWorkspace)));
actions.push(new Action('runtimeExtensionsEditor.action.disable', nls.localize('disable', "Disable"), undefined, true, () => this._disableExtensionWithPrompt(e.element!.marketplaceInfo!, EnablementState.DisabledGlobally)));
}
actions.push(new Separator());

Expand All @@ -510,6 +510,36 @@ export abstract class AbstractRuntimeExtensionsEditor extends EditorPane {
protected abstract _getUnresponsiveProfile(extensionId: ExtensionIdentifier): IExtensionHostProfile | undefined;
protected abstract _createSlowExtensionAction(element: IRuntimeExtension): Action | null;
protected abstract _createReportExtensionIssueAction(element: IRuntimeExtension): Action | null;

private async _disableExtensionWithPrompt(extension: IExtension, state: EnablementState): Promise<void> {
await this._extensionsWorkbenchService.setEnablement(extension, state);

const key = 'extensions.restartDismissed';
if (this._storageService.getBoolean(key, StorageScope.PROFILE, false)) {
return;
}

const restart = new Action('restart', nls.localize('restart', "Restart Extensions"), undefined, true, async () => {
await this._extensionService.stopExtensionHosts();
await this._extensionService.startExtensionHosts();
});

this._notificationService.prompt(
Severity.Info,
nls.localize('finishDisable', "Extension disabled. Restart extensions to take effect?"),
[{
label: nls.localize('restart', "Restart Extensions"),
run: () => restart.run()
}, {
label: nls.localize('later', "Later"),
run: () => { }
}],
{
sticky: true,
neverShowAgain: { id: key, isSecondary: true, scope: StorageScope.PROFILE }
}
);
}
}

export class ShowRuntimeExtensionsAction extends Action2 {
Expand Down
Loading