Make OSS product long name actually long #2983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Code - OSS' didn't look great in the launcher. Fixes #2982
|
I believe this was a purposeful choice. We don't want to apply the |
|
It might actually be useful in communication to refer to the distinction as "vscode" and "osscode" (or "oscode"?). This would have probably helped out in issue #60 (see comment 6). Compare to Chromium and Google Chrome. Maybe @chrisdias has an opinion on this? EDIT: Oops, looks like he was already just added to the conversation. |
|
The OSS version is just that - the OSS version, it is not Visual Studio. It is only "Visual Studio" when we build the distro which applies our branding, licensing, telemetry, etc. We should not merge this in. |
|
@chrisdias thanks for the clarification :) |
slodki
added a commit
to slodki/vscode
that referenced
this pull request
Jun 14, 2017
Clarifying product name and its licensing. Related to microsoft#60, microsoft#1230, microsoft#2982, microsoft#3029, microsoft#5342, microsoft#17996. Based on @chrisdias [comment](microsoft#2983 (comment)) and [comment](microsoft#60 (comment))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Code - OSS' didn't look great in the launcher.
Fixes #2982
@joaomoreno is this is fine for Windows and Mac? Matches format of official build.