Smoke test for multi root #31059
Merged
Smoke test for multi root #31059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the test fail when running on Mac OS/Linux? Does it leave any processes behind once finished? It would be good to have it working on all platforms with the same behaviour. |
|
@michelkaporin let's talk later in the office |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29570
@michelkaporin fyi my first attempt to have a smoke test for multi root with a generated workspace file. This test seems to not run properly on macOS or Linux, probably due to the "-" in the file name to open. For now I am only running the test on Windows where it seems to work just fine.