Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM: Support multiple repositories #31325

Merged
merged 73 commits into from
Aug 25, 2017
Merged

SCM: Support multiple repositories #31325

merged 73 commits into from
Aug 25, 2017

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Jul 24, 2017

  • Figure out API changes
  • Figure out status bar API changes
  • Update git to be multi-repo
  • Update automated smoketest
  • Review API changes w/ joh

@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues scm General SCM compound issues labels Jul 24, 2017
@joaomoreno joaomoreno added this to the August 2017 milestone Jul 24, 2017
@joaomoreno joaomoreno self-assigned this Jul 24, 2017
@@ -5447,14 +5452,17 @@ declare module 'vscode' {
export namespace scm {

/**
* The [input box](#SourceControlInputBox) in the Source Control viewlet.
* The [input box](#SourceControlInputBox) for the last source control
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move @deprecated to the top and enclose the rest in ~~ to strike it out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also explain the semantics of the 'old' deprecated inputBox, e.g last active one

*/
export const inputBox: SourceControlInputBox;

/**
* Creates a new [source control](#SourceControl) instance.
*
* @param id A unique `id` for the source control. Something short, eg: `git`.
* @param id An `id` for the source control. Something short, eg: `git`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this to type or context key?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense. Should I then create a type field in SourceControl and deprecate id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going with this proposal.

@joaomoreno joaomoreno merged commit 6b1c9cd into microsoft:master Aug 25, 2017
@joaomoreno joaomoreno deleted the scm-multiroot branch August 25, 2017 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues on-testplan plan-item VS Code - planned item for upcoming scm General SCM compound issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants