-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCM: Support multiple repositories #31325
Conversation
joaomoreno
commented
Jul 24, 2017
•
edited
Loading
edited
- Figure out API changes
- Figure out status bar API changes
- Update git to be multi-repo
- Update automated smoketest
- Review API changes w/ joh
src/vs/vscode.d.ts
Outdated
@@ -5447,14 +5452,17 @@ declare module 'vscode' { | |||
export namespace scm { | |||
|
|||
/** | |||
* The [input box](#SourceControlInputBox) in the Source Control viewlet. | |||
* The [input box](#SourceControlInputBox) for the last source control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move @deprecated
to the top and enclose the rest in ~~
to strike it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also explain the semantics of the 'old' deprecated inputBox
, e.g last active one
*/ | ||
export const inputBox: SourceControlInputBox; | ||
|
||
/** | ||
* Creates a new [source control](#SourceControl) instance. | ||
* | ||
* @param id A unique `id` for the source control. Something short, eg: `git`. | ||
* @param id An `id` for the source control. Something short, eg: `git`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this to type
or context key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would make sense. Should I then create a type
field in SourceControl
and deprecate id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going with this proposal.