Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleFindWidget Add next,previous,history: Fixes #29708 #29661 #32074

Closed

Conversation

cleidigh
Copy link
Contributor

@cleidigh cleidigh commented Aug 7, 2017

@rebornix
@Tyriar

  • Of course the last five percent was all the work
  • The need for a new context for FindInput Focused was somewhat messy
  • Had to touch more files than expected, was necessary as there are four clients
  • Re-FactoringTheFindWidget for common use everywhere will take quite a bit of work
    since it's so intertwined with the editor
  • Hopefully this is useful until we re- factor that

Fixes #29708 #29661 also services the modified simpleFindWidget to all users

@mention-bot
Copy link

@cleidigh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @joaomoreno to be potential reviewers.

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 7, 2017

@cleidigh Looks like something went wrong with the commit or PR. I only see whitespace diffs. Can you please try resubmitting the changes

@cleidigh
Copy link
Contributor Author

cleidigh commented Aug 7, 2017

@mjbvz
@rebornix
Sorry I seem to be in some kind of merge hell ... git is not cooperating.
May have to redo this PR.

@rebornix
Copy link
Member

rebornix commented Aug 8, 2017

@cleidigh maybe some rebasing and force push can help.

@cleidigh
Copy link
Contributor Author

cleidigh commented Aug 8, 2017

Closing and replacing with PR #32113

@cleidigh cleidigh closed this Aug 8, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find: No find history
5 participants