Make ExtensionTipsService multi-root aware #32106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
reviewed
Aug 24, 2017
| return []; | ||
| }).then<string[]>(null, err => []) | ||
| ) | ||
| ).then(flatten); |
| }, err => []); | ||
| return TPromise.join( | ||
| this.contextService.getWorkspace().roots.map(root => | ||
| this.fileService.resolveContent(root.with({ path: root.path + '/.vscode/extensions.json' })).then(content => { |
There was a problem hiding this comment.
I would use the old way paths to construct the path. This will make construct the path as per the platform
There was a problem hiding this comment.
That would use backslashes on Windows, which is not valid in a URI
There was a problem hiding this comment.
That would use backslashes on Windows
True, but it is a valid file path. Creating an URI using URI.file takes care of it
Good thing is it will hide the knowledge of path separators.
|
Resolved the conflicts and pushed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #29242
Collects extension recommendations from all roots instead of only for the first root.