Fix tests and out of bounds in scorer #34576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was a noop, because sort sorted `scores` as well. After this change, the test fails. It passes after the following changes: * hw should be a higher score than just H, since the w appears after a word separator. * Same with ld and L. * Change target so that L comes before l. The scorer algorithm is greedy, so will not match the upper case L otherwise, which is the point of that specific case.
`indexOf` is the index into `target`, while `index` is the correct index into `query`.
|
I noticed a simple performance improvement as well, which I also just pushed into this PR. |
|
@keegancsmith nice findings, thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.