Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use os-specific EOL while creating the copyrightHeader for hygiene checks #3834

Closed
wants to merge 2 commits into from
Closed

use os-specific EOL while creating the copyrightHeader for hygiene checks #3834

wants to merge 2 commits into from

Conversation

kumarharsh
Copy link
Contributor

Right now, the hygiene checks fail on windows machines because the copyrightHeader standard is being by joining an array of strings with a \n, which doesn't work on Windows with it's CRLF line-endings. This PR addresses that by using OS-specific line endings while building the copyrightHeader standard string.

@msftclas
Copy link

msftclas commented Mar 8, 2016

Hi @kumarharsh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@kumarharsh kumarharsh closed this Mar 8, 2016
@kumarharsh kumarharsh deleted the feature/eol-hygiene branch March 8, 2016 11:42
@kumarharsh
Copy link
Contributor Author

bad PR, closing

@joaomoreno joaomoreno removed their assignment Mar 8, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants