Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to update workspace folders #42026

Merged
merged 25 commits into from
Jan 26, 2018
Merged

Add API to update workspace folders #42026

merged 25 commits into from
Jan 26, 2018

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jan 23, 2018

fixes #35407

@bpasero bpasero added this to the January 2018 milestone Jan 23, 2018
@bpasero bpasero self-assigned this Jan 23, 2018
@wangpung12
Copy link

Good

@bpasero
Copy link
Member Author

bpasero commented Jan 25, 2018

@jrieken ready for some feedback. as discussed the WorkspaceFolder is now a live object (even for the case of the normal $acceptWorkspaceData). On top of that, there is now an unconfirmed workspace that is used for all extension host manners until $acceptWorkspaceData is called. Only for the events we actually use the _confirmedWorkspace to be able to compute the true events from the previous confirmed state.

@bpasero
Copy link
Member Author

bpasero commented Jan 25, 2018

@jrieken I added some tests. fyi I noticed that none of the onDidChangeWorkspace reported a failure when the assertion fails. I think errors in event handlers are silently ignored unless you pass them out to the done handler.

@bpasero bpasero merged commit 59ec992 into master Jan 26, 2018
@bpasero bpasero deleted the ben/workspace-api branch January 26, 2018 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide additional workspace API (read / write)
3 participants