Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new notifications UX #43770

Merged
merged 73 commits into from
Feb 19, 2018
Merged

Implement new notifications UX #43770

merged 73 commits into from
Feb 19, 2018

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Feb 15, 2018

flicker_chrome58

@lukewis
Copy link

lukewis commented Mar 28, 2018

@bpasero , are there any docs on the keyboard accessibility? I've been trying to figure out how to get the keyboard to dismiss a notification, but I'm coming up empty.

@bpasero
Copy link
Member Author

bpasero commented Mar 28, 2018

@lukewis here are the keybindings:

image

@lukewis
Copy link

lukewis commented Mar 28, 2018

@bpasero Wow. Never knew that existed. Opened up a whole new world for me! Thanks for helping out a newbie!

@ndarilek
Copy link

ndarilek commented Jan 9, 2019

VSCode newbie here. I'm a screen reader user and am struggling with this issue. After chasing it through several closed/locked issues, I've found this PR, which includes an image I can't read of the relevant keybindings. :)

First, is this fix available in whatever version I'd get if I go to the download page and perform a fresh install? I don't have the relevant VM booted so I'm not sure what version I have, or if I still need to be on the insider build. This installation is new as of yesterday, so is fairly representative of what a new user would get.

Then, how do I go about interacting with notifications via the keyboard? I can tab to them, but any yes/no notifications are unusable to me. Ironically I hit this with the initial "Are you using a screen reader?" notification, which I couldn't click Yes on. :) I've looked through accessibility documentation, but haven't found anything about interacting with notifications.

Thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants