Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defining span to definition provider API #45249

Closed
wants to merge 2 commits into from

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Mar 8, 2018

Supersedes #40045

Problem
See #10037

Proposal
Adds a new resolveDefinitionContext to DefinitionProvider. This allows a definition provider to return the defining symbol span.

Supersedes #40045

**Problem**
See #10037

**Proposal**
Adds a new `resolveDefiniotionContext` to `DefinitionProvider`. This allows a definition provider to return the defining symbol span.
@mjbvz mjbvz added this to the March 2018 milestone Mar 8, 2018
@mjbvz mjbvz self-assigned this Mar 8, 2018
@mjbvz mjbvz requested a review from jrieken March 8, 2018 03:13
@jrieken
Copy link
Member

jrieken commented Mar 8, 2018

Based on current plan stretch for March esp. since we should understand what this means to ImplementationProviders, GoToTypeDefProvider

@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 8, 2018

Yes good to consider those other providers too for the design of the api, but we only need the defining symbol range for the DefinitionProvider mouse ui currently. I think our goal here should be to come up with a general api pattern that we could also use in those other providers if needed

@mjbvz mjbvz modified the milestones: March 2018, April 2018 Apr 3, 2018
@mjbvz mjbvz mentioned this pull request Apr 16, 2018
@mjbvz mjbvz modified the milestones: April 2018, May 2018 Apr 26, 2018
@bpasero bpasero modified the milestones: May 2018, June 2018 Jun 7, 2018
@isidorn isidorn modified the milestones: June 2018, July 2018 Jun 29, 2018
@mjbvz mjbvz closed this Jul 18, 2018
@mjbvz mjbvz deleted the definition-and-span-provider2 branch July 24, 2018 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants