Remove prompt to install packs for core languages #52827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@ramya-rao-a Thanks for the PR. I discussed with @dbaeumer about this and we decided to have this prompt for a milestone. Reason being, it will be easy to revert if there are issues. So planning this for next milestone. |
|
So are we going to continue to ship the core languages out of the box for June? |
|
@ramya-rao-a No, we do not ship core languages. We just want to have minimal changes to revert to VS Code with core languages, in case if there is an issue. |
|
ping @sandy081 Do we want to keep this around for another milestone? |
|
Lets target this change for August |
|
In that case, I'll go ahead and merge this if you are ok with the changes |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we dont ship core language support out of the box, the prompt that we intend to do so in the future is not needed.
Related to #50588
cc @sandy081