-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InstantiationService debt #5443
Conversation
…tart with createChild
By analyzing the blame information on this pull request, we identified @egamma, @aeschli and @alexandrudima to be potential reviewers |
@jrieken two questions about the workflow you are using for development (not really related to this PR, just want to start discussion and open a thread later if we will need):
|
Thanks for the feedback. I hope I can provide some answers:
That's correct. We all work against master and don't do pull requests so often. This works well for us because we self host very aggressively - it happens we update alpha a few times a day. So people will notice breakage quickly and there is no hesitation to revert a change. Usually changes become less wild towards the end of a month. That is because we start a new iteration every month which usually starts with one week debt/exploration work, two weeks feature work, and one week testing/stabilisation. Then we might do pull requests, reviews, and/or program in pairs.
I like that suggestion. Esp. with the recent introduction of merge&squash we should do this more often. It's not a rule but everyone should include an issue number when pushing. When doing debt work that often gets forgotten and we should improve on that.
The work is tracked in our monthly plans. My recent debt work on service injection got forgotten because it spun-off a water cooler discussion and I just jumped right on... More on our workflow can be found here: https://github.com/Microsoft/vscode/blob/master/wiki/project-management/development-process.md
We provide an birds eye view on how stuff is organised and I'd love to receive some feedback. Because doc comments are usually outdated quickly we have decided to use only TypeScript's type annotations for our internal APIs. fyi @egamma |
@jrieken thank you for answers! It helped to understand the process. I am new for VS Code, liked the concept of really simple editor with few advanced options. Gives me some thoughts of switching from
@jrieken you said "it happens we update alpha a few times a day" - how to get on alpha channel? |
Currently the alpha channel is internal. Now that 1.0 is out we will revisit this. |
No description provided.