Investigate Electron 3.0.x

.yarnrc

@@ -1,3 +1,3 @@
 disturl "https://atom.io/download/electron"
-target "2.0.12"
+target "3.0.10"
 runtime "electron"

cgmanifest.json

@@ -6,7 +6,7 @@
 				"git": {
 					"name": "chromium",
 					"repositoryUrl": "https://chromium.googlesource.com/chromium/src",
-					"commitHash": "7accc8730b0f99b5e7c0702ea89d1fa7c17bfe33"
+					"commitHash": "164c37e3f235134c88e80fac2a182cfba3f07f00"
 				}
 			},
 			"licenseDetail": [
@@ -40,45 +40,45 @@
 				"SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE."
 			],
 			"isOnlyProductionDependency": true,
-			"version": "61.0.3163.100"
+			"version": "66.0.3359.181"
 		},
 		{
 			"component": {
 				"type": "git",
 				"git": {
 					"name": "libchromiumcontent",
 					"repositoryUrl": "https://github.com/electron/libchromiumcontent",
-					"commitHash": "ccdb085454b0a387ee96e0f81a7ca9a8ce07a710"
+					"commitHash": "d9e39391cfae447a84e276a402342cf8b4b5bcba"
 				}
 			},
 			"isOnlyProductionDependency": true,
 			"license": "MIT",
-			"version": "61.0.3163.100"
+			"version": "66.0.3359.181"
 		},
 		{
 			"component": {
 				"type": "git",
 				"git": {
 					"name": "nodejs",
 					"repositoryUrl": "https://github.com/nodejs/node",
-					"commitHash": "8a44289089a08b7b19fa3c4651b5f1f5d1edd71b"
+					"commitHash": "5cbb905c1af7cea2d709932d59827d7c6d03ef4a"
 				}
 			},
 			"isOnlyProductionDependency": true,
-			"version": "8.9.3"
+			"version": "10.2.0"
 		},
 		{
 			"component": {
 				"type": "git",
 				"git": {
 					"name": "electron",
 					"repositoryUrl": "https://github.com/electron/electron",
-					"commitHash": "d281859cf59f12c7107a540a9f4cba0ecf5eff41"
+					"commitHash": "4305657858592be2b44c95ae7af53c627dcdc5e7"
 				}
 			},
 			"isOnlyProductionDependency": true,
 			"license": "MIT",
-			"version": "2.0.12"
+			"version": "3.0.10"
 		},
 		{
 			"component": {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "code-oss-dev",
   "version": "1.31.0",
-  "distro": "573bd4fedabe1c0bcebeb1e683109079ae560312",
+  "distro": "2fc810c2f29040b34dbeab2be175a22cca2624db",
   "author": {
     "name": "Microsoft Corporation"
   },
@@ -63,7 +63,7 @@
     "@types/keytar": "^4.0.1",
     "@types/minimist": "^1.2.0",
     "@types/mocha": "2.2.39",
-    "@types/node": "^8.9.1",
+    "@types/node": "^10.12.12",
     "@types/semver": "^5.5.0",
     "@types/sinon": "^1.16.36",
     "@types/webpack": "^4.4.10",

src/bootstrap-window.js

@@ -51,9 +51,8 @@ exports.load = function (modulePaths, resultCallback, options) {
 	// Enable ASAR support
 	bootstrap.enableASARSupport(path.join(configuration.appRoot, 'node_modules'));
 
-	// disable pinch zoom & apply zoom level early to avoid glitches
+	// Apply zoom level early to avoid glitches
 	const zoomLevel = configuration.zoomLevel;
-	webFrame.setVisualZoomLevelLimits(1, 1);
 	if (typeof zoomLevel === 'number' && zoomLevel !== 0) {
 		webFrame.setZoomLevel(zoomLevel);
 	}

src/main.js

@@ -147,10 +147,8 @@ function onReady() {
  */
 function configureCommandlineSwitches(cliArgs, nodeCachedDataDir) {
 
-	// TODO@Ben Electron 2.0.x: prevent localStorage migration from SQLite to LevelDB due to issues
-	app.commandLine.appendSwitch('disable-mojo-local-storage');
-
 	// Force pre-Chrome-60 color profile handling (for https://github.com/Microsoft/vscode/issues/51791)
+	// TODO@Ben check if future versions of Electron still support this flag
 	app.commandLine.appendSwitch('disable-features', 'ColorCorrectRendering');
 
 	// Support JS Flags