position scrollbar for settings on far-right

[itamark]

Solves #55795

[itamark]

@ramya-rao-a @roblourens any idea why VSTS: VS Code is failing so much?

[ramya-rao-a]

A unit test in master is failing. It has nothing to do with your changes. We will most likely get to it on Monday.

[roblourens]

Now the shadow extends to the right too, and it should only go over the settings tree area. Also it should extend over the TOC too. That's why I had some of the weirdness before with the absolutely positioned TOC on top of of the settings tree.

Personally I'm not a fan of the shadow anyway, and it's complicating things for us here, but we have to keep it for now.

[itamark]

@roblourens Okay I limited the width of the container and its shadow to not extend as far as the entire scrollable area does.

[roblourens]

Is it possible to get the shadow to show over the TOC like it did before though?

Currently the settings list shadow shows over both lists, and the TOC shadow is hidden. I don't want to change that yet.

If it's not possible to do that without jumping through hoops or changing the DOM structure, let me know. I'm not a huge fan of the shadow here, we might be able to get rid of it.

[itamark]

I'll take care of it tomorrow 😊

[itamark]

@roblourens It would be a bit of a thing to get that shadow back. Plus, I think it's incorrect to have the TOC shadowed. The tree is the thing that's scrolling - not the TOC, no?

[roblourens]

Well, we don't want to have separate shadows for the trees right next to each other, and we think it looks weird for the settings list to just have a shadow that cuts off at the TOC, so this was the compromise... I still want to do something different here like just remove the shadow entirely... I'll just leave this open for now.

[itamark]

@roblourens I gave it another shot and was able to figure it out.

[roblourens]

It looks like the tree isn't able to shrink properly:

With overriding the scrollbar positioning and everything this might be getting to a hack level that I don't want to take.

[roblourens]

Going in a slightly different direction but thanks for your work on this :)

[itamark]

No worries! I'm really enjoying contributing to this project!

…

On Fri, Sep 21, 2018, 4:10 AM Rob Lourens ***@***.***> wrote: Going in a slightly different direction but thanks for your work on this :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#56167 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABrQ0dD0KsXiKlS_13o7mFeYO5X4XNlaks5udDyIgaJpZM4V4s15> .