Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding electron ARM and ARM64 tasks for cross-compiling #58436

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Adding electron ARM and ARM64 tasks for cross-compiling #58436

merged 1 commit into from
Sep 11, 2018

Conversation

headmelted
Copy link
Contributor

@headmelted headmelted commented Sep 11, 2018

This follows on from pull request #52119.

Adding these tasks will allow for explicitly downloading ARM and ARM64 versions of Electron when it is not the native architecture of the build machine (this is helpful for cross-compilation scenarios).

Adding tasks to allow for explicitly download ARM and ARM64 versions of Electron when it is not the native architecture of the build machine (for cross-compiling).
@joaomoreno joaomoreno added this to the September 2018 milestone Sep 11, 2018
@joaomoreno joaomoreno self-assigned this Sep 11, 2018
@joaomoreno joaomoreno merged commit 25832c1 into microsoft:master Sep 11, 2018
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Sep 11, 2018
@joaomoreno
Copy link
Member

Thanks! 🍻

@headmelted
Copy link
Contributor Author

Thanks for the fast turnaround 👍

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants