First PR: Adding jump to nth autocomplete suggestion via keyboard shortcut #58670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
👍 Perhaps it makes sense not only to select the suggestion, but to insert it right away? |
|
@helsont this will take a while tbh. @ramya-rao-a is leaving the team and things are parked here until a new owner is found |
|
@helsont Are you still interested in carrying this on? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue: #52549
Hi! This is my first PR and I'd like to get feedback on my general approach before I dig any deeper.
I know that the particular configurations of my key bindings can be improved and I don't know what
case State.Detailsrepresents. Feedback and help appreciated here!More generally, is the new function
selectNthSuggestionok? What about the for loop to go through and add the bindings? How's the id for the key binding?Please be as honest as possible as it's my first PR and I'd like to learn quickly!