Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix R icon size #59891

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Fix R icon size #59891

merged 1 commit into from
Oct 4, 2018

Conversation

yeahok
Copy link
Contributor

@yeahok yeahok commented Oct 3, 2018 •
edited
Loading

Fixes #57595

@miguelsolorio
Copy link
Contributor

Wouldn't this need to be fixed upstream in order for us to update our version? I see there's a PR for this but it's not yet merged.

@yeahok
Copy link
Contributor Author

yeahok commented Oct 3, 2018

Yeah I made the other pull request too with the same fix. I probably jumped the gun a bit. Should this pull request be closed?

@aeschli
Copy link
Contributor

aeschli commented Oct 4, 2018

@yeahok Cool, thanks a lot. I've seen you filed jesseweed/seti-ui#509.
As jesseweed/seti-ui uually takes a while to go through the PRs, I already push it here.

@aeschli aeschli merged commit a7b8fdb into microsoft:master Oct 4, 2018
@aeschli aeschli added this to the October 2018 milestone Oct 4, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
October 2018
Development

Successfully merging this pull request may close these issues.

[theme] seti R Icon too large
3 participants
@yeahok @miguelsolorio @aeschli