Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scc providers hide commit input box. #60051

Conversation

IlyaBiryukov
Copy link

Fix for #51808.

@joaomoreno joaomoreno added this to the October 2018 milestone Oct 9, 2018
@joaomoreno joaomoreno added the scm General SCM compound issues label Oct 9, 2018
@joaomoreno joaomoreno merged commit 212aade into microsoft:master Oct 23, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Oct 23, 2018

Review notes:

  1. There already is a SourceControlInputBox object in the API. This feature should just be a visible property on that object.
  2. The current implementation doesn't actually react on changes to that visible property, it just relies on the value when the SCM repository gets rendered, which is sub-optimal.

I've addressed both these issues and merged this in: f1f5385

Thanks! 🍻


@jrieken Sorry for sidelining this, but this introduces a new proposed API: one which allows to hide a source control provider's input box. Let me know if you want me to bring it up for review in the API call. Here's the signature:

https://github.com/Microsoft/vscode/blob/f1f5385a68bfab396232054a3bb573aa16a05e1d/src/vs/vscode.proposed.d.ts#L729:L738

@jrieken
Copy link
Member

jrieken commented Oct 24, 2018

It's OK if it is just proposed but I find the scenario rather weird and LS specific. Would a real source control provider ever want to hide its input field? Should this be linked with the fact that the file system in readonly and then the main side automagically hides/disables the input box?

@jrieken
Copy link
Member

jrieken commented Oct 24, 2018

fyi - this has caused #61676 and the merge has been reverted

@joaomoreno
Copy link
Member

@jrieken Thanks for jumping on it.

🤦‍♂️ e337569

I am embarrassed.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scm General SCM compound issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants