Quote args for bash, fixes #61056 #61409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TerminalLauncher does not properly escape arguments for the Bash shell. This change wraps all arguments in single-quotes, and escapes the single quote. This means that bash special characters in arguments will not be evaluated.
Brcrwilliams
force-pushed
the
escape-args
branch
from
8ed07dd
to
6d07235
Compare
weinand
added
the
debug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TerminalLauncher does not properly escape arguments for the Bash
shell. This change wraps all arguments in single-quotes, and escapes the
single quote. This means that bash special characters in arguments will not be
evaluated.