multiline breakpoint widget - implementing #56521 #61859
Conversation
|
|
|
Thanks for the PR. |
| @@ -127,6 +127,16 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi | |||
| } | |||
| } | |||
|
|
|||
| public show(rangeOrPos: IRange | IPosition, _: number) { | |||
There was a problem hiding this comment.
Use a proper name, not _ even though it is not used
| @@ -127,6 +127,16 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi | |||
| } | |||
| } | |||
|
|
|||
| public show(rangeOrPos: IRange | IPosition, _: number) { | |||
| let lineNum = this.input.getModel().getLineCount(); | |||
There was a problem hiding this comment.
I prefer const to let if it will not be mutated, so can you please use const
| @@ -144,6 +154,9 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi | |||
| this.createBreakpointInput(dom.append(container, $('.inputContainer'))); | |||
|
|
|||
| this.input.getModel().setValue(this.getInputValue(this.breakpoint)); | |||
| this.input.getModel().onDidChangeContent(() => { | |||
There was a problem hiding this comment.
This is a listener, add it to the this.toDispose
| } | ||
|
|
||
| public fitHeightToContent() { | ||
| let lineNum = this.input.getModel().getLineCount(); |
There was a problem hiding this comment.
Same here, please use const
|
@YisraelV great work, I really like it. I checked for the css change, and I can no longer reproduce the original bug so we are good there. You do not have to worry about that. |
isidorn
added
the
debug
|
@isidorn that's very nice to hear thank you very much. I made the requested changes. Would you like me to squash my two commits into 1? |
|
@YisraelV no need for squashing, merging it in. Thanks a lot! |
No description provided.