Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workbench): add preference to disable recently used tasks #61994

Closed
wants to merge 1 commit into from
Closed

fix(workbench): add preference to disable recently used tasks #61994

wants to merge 1 commit into from

Conversation

kumarharsh
Copy link
Contributor

Closes #30419

kumarharsh
kumarharsh commented Oct 28, 2018
View reviewed changes
src/vs/base/common/map.ts Outdated Show resolved Hide resolved
dbaeumer
dbaeumer requested changes Oct 30, 2018
View reviewed changes
src/vs/base/common/map.ts Outdated Show resolved Hide resolved
src/vs/workbench/electron-browser/main.contribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts Outdated Show resolved Hide resolved
@dbaeumer dbaeumer added this to the November 2018 milestone Nov 15, 2018
@dbaeumer
Copy link
Member

I am very busy the next couple of days. Needs to wait a little. Sorry for that.

@kumarharsh
Copy link
Contributor Author

Sure, no problem.

@roblourens roblourens removed this from the December/January 2019 milestone Feb 1, 2019
@alexr00 alexr00 added this to the June 2019 milestone May 27, 2019
alexr00
alexr00 requested changes Jun 5, 2019
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the setting name, we must make it task instead of tasks because tasks is already used for the tasks themselves. That needs to be changed in both files. You can test that the setting is ok by using it in the settings UI.
I ran task five, four, three, two, and then one.
Order of tasks in insiders:
image
Order of tasks with this change:
image

@alexr00
Copy link
Member

alexr00 commented Jun 5, 2019

Also please resolve the merge conflicts!

@alexr00 alexr00 modified the milestones: June 2019, On Deck Jun 21, 2019
@hypercubestart hypercubestart mentioned this pull request Sep 11, 2019
Closed
@alexr00
Copy link
Member

alexr00 commented Oct 21, 2019

@kumarharsh Thank you for laying the ground-work for this change. The start you made was finished and merged in #82757.

@alexr00 alexr00 closed this Oct 21, 2019
@alexr00 alexr00 modified the milestones: On Deck, October 2019 Oct 21, 2019
@kumarharsh
Copy link
Contributor Author

Thanks @alexr00 :)

@kumarharsh kumarharsh deleted the feat/recent-task-pref branch October 22, 2019 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbaeumer dbaeumer dbaeumer requested changes

@alexr00 alexr00 alexr00 requested changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.

Add preference to turn off "recently used tasks"
4 participants
@kumarharsh @dbaeumer @alexr00 @roblourens