Fixed isUpdateAvailable in updateService.snap.ts to correctly identify snap version #64392
Conversation
- Fixed isUpdateAvailable in updateService.snap.ts to correctly identify snap version - Also fixed a small typo in doCheckForUpdates - Removed check in function doQuitAndInstall
|
Hello again, I was just looking at the shell script in snapUpdate.sh that is available in the code-insiders package. At present it just seems to be doing the following. #!/bin/sh If instead it was written like the following, both the snapcrafters version and vscode-insiders should work and function identically. I have tested this works #!/bin/sh I hope this is useful. |
Good to know, care to push that to the PR as well? |
|
|
|
I have added the changes to snapUpdate.sh. Is there anything else needed for this PR? Without this patch, I am currently getting ENOENT: no such file or directory, lstat '/snap/code'. |
joaomoreno
added
linux
|
What is the implication for those experiencing the bug with 1.30.0? Does this break the update and if so, do we need to take action to work around? I'm thinking I just need to reinstall the snap package when an update is available. |
|
@HankB The snap package and update mechanism is external. The code that was broken was the function to check if a new version is available. If true, the code ATM is supposed to simply close and reopen the program. You don't need to do anything but wait till the next version is released. |
|
What is a plan of snap updates? It's a 16th of January, and that error is still annoying. |
|
@doubledare704 From what I can understand. It appears that this patch is lined up for the December/January 2019 milestone. I don't think this was included in the November Milestone but others can correct me otherwise. At least that is my interpretation based on these milestone tags. |
Hello again,
I seem to have missed this line of code from #63716.
This change should occur for the exact same reason as the above PR.
In this case, the snap and product.applicationName is expecting the snap to be mounted at
/snap/code/current. It is instead mounted at /snap/vscode/current.
The non-null assertion operator should be safe as the environment variable is checked at construction. I Although a similar check also appears to occur in doQuitAndInstall. I have removed that check and used the non-null assertion operator.If this isn't correct, I am happy to change it.
Running "grep -nr '
/snap/${product.applicationName}/current' . " does not produce anymore results.I am sorry for missing this in the initial PR.