electron 3.0.x - try to fix keybindings in webviews #64417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
added a commit
that referenced
this pull request
Dec 10, 2018
* update to 3.0.0-beta.3 * update d.ts files; rename NodeBuffer => Buffer * update to 3.0.0-beta.4 * undo invalid change * remove some Electron 2.0.x specific workarounds * pinch zoom is now disabled by default * update vscode-nsfw * change vscode-nsfw * update smoke test electron version * streams: use destroy() over close() * workaround broken tests * bump distro and OSS * try to bump node version for build * update macOS build to use node.js 10.8.0 * fix extension tests * use node.js 10.2.1 for all builds * remove nsfw from dev dependencies * back to node 8.x for build * Revert "back to node 8.x for build" This reverts commit 90ea2b7. * update distro * disable test run on macOS prod build for now * bump distro * ensure proper nsfw dep * fix more native dependencies * temp disable failing test * fix packages * update deps * fix deps * update deps * enable macOS unit tests again * fix deprecated buffer use * Electron 3.0.0.beta.5 * bump deps * fix tree accidentally treating auxclick as click * improve overlay cleanup scheduler (fixes flicker seen with Electron 3.0.x) * update distro * remove obsolete disableBlinkFeatures: 'Auxclick' * update to Electron 3.0 beta 6 * fix compile * workaround #56994 * do not use backgroundColor to find shared process (causes flicker) * fix flicker on windows from shared process background color * webview - bubble up keyboard events (workaround for #56988) * bump electron to 3.0.0-beta.8 * webview - fix deprecation * webview - fix another deprecation * debt - handle SIGPIPE on more processes * workaround more webview focus issues (for #56988) * webview - use proper way to focus() * debt - avoid window-focus/blur and use native focus events instead * webview - restore previous focus method * webview - improve focus tracking (do not rely on DOM events) * bump to electron 3.0.0-beta.9 * update deps * update electron@3.0.0-beta.10 * webview - do not rely on DOM focus for certain commands (for #56988) * update to electron@3.0.0-beta.11 * electron@3.0.0-beta.12 * update to beta 13 * update to electron 3.0.0 * update to Electron 3.0.1 * electron@3.0.2 * revert build changes (node.js version) * try with: enable mojave dark mode support * fix types * electron 3.0.3 * electron@3.0.4 * fix deps * bump electron@3.0.6 * bump electron@3.0.9 * fix strict null issue * reset format * bump electron@3.0.10 * fix strict null issue * webview - print error when revive fails * electron 3.0.x - try to fix keybindings in webviews (#64417) * bump @types/node => ^10.12.12 * 💄 * update distro
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.