Fix cmd+down on search result focusing editor #68182
Conversation
…serveFocus=false
| } | ||
|
|
||
| export function getSelectionKeyboardEvent(typeArg: string, preserveFocus?: boolean): SelectionKeyboardEvent { | ||
| const e = new KeyboardEvent(typeArg); |
There was a problem hiding this comment.
KeyboardEvent does not like to be subclassed
|
Change looks good to me and seems to work when I built it. @joaomoreno should review as well |
|
@joaomoreno you can merge it if it's good |
There was a problem hiding this comment.
With this change, we are hard-coding the list.select command to never preserve focus... which I'm not entirely sure we should do. Was this true in the latest stable? If so, merge away. Otherwise, I would be careful with it.
For the future, it seems to be list.select is bogus. We should introduce a list.open command which could handle a preserveFocus argument.
|
If I am reading this correctly, that was the case with list.select and the other resource navigator too. |
|
this is probably causing #68515 |
Fix #68018