Include triple-stash bracket and add brace to surroundingPairs #68833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundingPairs
Triple-stash {{{ ... }}} is used to surround an expression that should not be escaped for HTML
Having the option to enable surroundingPairs for brace would simplify the editing experience
|
Thanks for the PR @productiveme! We get this grammar from https://github.com/daaain/Handlebars, so this PR should go to that repo. Once it's merged in there, I'll pull the grammar into VS Code again. |
|
Hi @alexr00, I had a look at the repo you mentioned, but don't see the visual studio grammer there, do you do a manual implementation based on the principles in that repo? |
|
@jacoswarts, you are correct the language-configuration.json file comes from VS Code. I've re-opened your PR and I'll take a look. |
alexr00
approved these changes
Feb 19, 2019
sandy081
pushed a commit
to vldmrkl/vscode
that referenced
this pull request
Feb 22, 2019
…oundingPairs (microsoft#68833) Triple-stash {{{ ... }}} is used to surround an expression that should not be escaped for HTML Having the option to enable surroundingPairs for brace would simplify the editing experience
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triple-stash {{{ ... }}} is used to surround an expression that should not be escaped for HTML
Having the option to enable surroundingPairs for brace would simplify the editing experience